Keep stdout buffers to concat instead of converting to strings#2270
Merged
Keep stdout buffers to concat instead of converting to strings#2270
Conversation
This seems to fix an issue with some unicode characters becoming "broken" which is likely when their bytes split across buffers and we convert them to strings before joining back together. Fixes #2140.
DanTup
force-pushed
the
fix-format-encoding-issue
branch
from
bf26781 to
d0c40e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to fix an issue with some unicode characters becoming "broken" which is likely when their bytes split across buffers and we convert them to strings before joining back together.
Fixes #2140.