Add Create Offline Configuration#2311
Conversation
|
Issues : |
DanTup
left a comment
DanTup
left a comment
There was a problem hiding this comment.
Thanks for this! I added some minor comments, but otherwise it looks good. Thanks!
| if (config.flutterCreateOffline) { | ||
| args.push("--offline"); | ||
| } |
There was a problem hiding this comment.
It looks like this argument might be being added twice?
| get flutterAndroidX(): boolean { return this.getConfig<boolean>("flutterAndroidX", false); } | ||
| get flutterCreateAndroidLanguage(): "java" | "kotlin" { return this.getConfig<"java" | "kotlin">("flutterCreateAndroidLanguage", "kotlin"); } | ||
| get flutterCreateIOSLanguage(): "objc" | "swift" { return this.getConfig<"objc" | "swift">("flutterCreateIOSLanguage", "swift"); } | ||
| get flutterCreateOffline(): boolean { return this.getConfig<boolean>("flutterCreateOffline", true); } |
There was a problem hiding this comment.
This true should be false (it should match the default value).
| "dart.flutterCreateOffline": { | ||
| "type": "boolean", | ||
| "default": false, | ||
| "description": "Whether to create new flutter project using offline mode", |
There was a problem hiding this comment.
Nit: Should end with full stop to match the others.
DanTup
added
in flutter
|
I'm planning on a beta release shortly, so I'll merge this and tidy up the small things mentioned above. Thanks! |
sorry got no change of working it, kinda busy setting up new laptop. thanks by the way for merging it ! |
|
No worries - I merged it and made those tweaks. It's in the beta I released today: https://github.com/Dart-Code/Dart-Code/releases/tag/v3.9.0-beta.1 And will ship in the stable release (aiming for end of this week). Thanks for the contribution! |
2 participants
Fixes #1957.