Skip to content

Switch dart.progress for DAP progress events#2540

Merged
DanTup merged 3 commits intoDart-Code:masterfrom
BootBlock:dap-progress
Jun 17, 2020
Merged

Switch dart.progress for DAP progress events#2540
DanTup merged 3 commits intoDart-Code:masterfrom
BootBlock:dap-progress

Conversation

@BootBlock
Copy link
Contributor

Fixes #2516.

@DanTup
Copy link
Member

DanTup commented Jun 17, 2020

Thanks! I caused some conflicts with this, so I've rebased your branch over master and fixed up.

I also changed this to pass an empty title:

this.sendEvent(new ProgressStartEvent(debugLaunchProgressId, "", "Launching..."));

It's not clear if this is allowed (the spec says title is mandatory), but I've filed microsoft/language-server-protocol#1025 for clarification. If it's not allowed, I think there should be a way to allow us to have single-message updatable progress without needing to have two messages joined with colons.

@DanTup DanTup added this to the v3.12.0 milestone Jun 17, 2020
@DanTup DanTup added in debugging Relates to the debug adapter or process of running debug sessions is enhancement An enhancement or improvement that should be listed in release notes but is not a bug fix. labels Jun 17, 2020
@DanTup DanTup merged commit c4b51c4 into Dart-Code:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in debugging Relates to the debug adapter or process of running debug sessions is enhancement An enhancement or improvement that should be listed in release notes but is not a bug fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate dart.progress events to use DAP's progressEvent

2 participants