Switch dart.progress for DAP progress events#2540
Merged
DanTup merged 3 commits intoDart-Code:masterfrom Jun 17, 2020
BootBlock:dap-progress
Merged
Switch dart.progress for DAP progress events#2540DanTup merged 3 commits intoDart-Code:masterfrom BootBlock:dap-progress
DanTup merged 3 commits intoDart-Code:masterfrom
BootBlock:dap-progress
Conversation
Member
|
Thanks! I caused some conflicts with this, so I've rebased your branch over master and fixed up. I also changed this to pass an empty title: It's not clear if this is allowed (the spec says title is mandatory), but I've filed microsoft/language-server-protocol#1025 for clarification. If it's not allowed, I think there should be a way to allow us to have single-message updatable progress without needing to have two messages joined with colons. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2516.