Move debug adapters back out-of-process#2711
Merged
Conversation
2ed3b73 to
f3a158d
Compare
f3a158d to
f309fef
Compare
…est() This could cause TerminatedEvent() not to be picked up by tests when running out of process as the base disconnectRequest would immediately shutdown while the TerminatedEvent was still in its timeout.
If these events didn't occur the test would fail, but then after the timeout period (eg. 60 seconds later) this would throw and result in a message logged during the running of a different test, which can be confusing to track down.
If these events didn't occur the test would fail, but then after the timeout period (eg. 60 seconds later) this would throw and result in a message logged during the running of a different test, which can be confusing to track down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.