Prefilled project name#2994
Merged
DanTup merged 4 commits intoDart-Code:masterfrom Dec 8, 2020
BootBlock:prefilled-project-name
Merged
Prefilled project name#2994DanTup merged 4 commits intoDart-Code:masterfrom BootBlock:prefilled-project-name
DanTup merged 4 commits intoDart-Code:masterfrom
BootBlock:prefilled-project-name
Conversation
Now asks for the project folder first, so it can determine a unique project name for creation should the pre-filled name be accepted within the corresponding dialog. Project name determination only occurs for the initial, pre-filled name suggestion and will not apply if a different name is entered entirely. Fixes #2989.
Project name pre-filling now always ends in a number (eg. `my_project_1`, `my_project_2`) rather than using a file copy duplication style (eg. `my_project`, `my_project_1`). In-place error during project naming should a directory with the specified name already exist. This negates the need of having to reinvoke the create project command to begin creating a project again.
Replaces multiple fsPath() calls with a variable counterpart.
DanTup
added
in commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-fills name upon creating a new project. Project name determination only occurs for the initial, pre-filled name suggestion and will not apply if a different name is entered entirely.
Displays an in-place error during (user input) project naming should a directory with the specified name already exist. This negates the user needing to reinvoke the create-project command to begin creating a project again.
Optimises out multiple
fsPath() calls.