style: add return type of main#3589
Merged
DanTup merged 1 commit intoDart-Code:masterfrom Oct 5, 2021
Merged
Conversation
DanTup
added
in editor
Contributor
Author
|
I think there's something funny going on with tests. |
Member
|
Thanks! I don't believe either of the test failures are related to this. One is a known problem and the other looks like the SDK update check got a status 200 but not valid JSON and didn't handle that correctly. I'll improve the handling of that on the main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could be subjective, but I think it's good to have a return type on every function. Every time I use the
mainsnippet I find myself writing void anyway. You could also argue that I could make my own snippet, and that's true. But because dart is typed after all andfunuses void, why not?