Include unsupported devices sidebar in API device events#4831
Merged
Conversation
DanTup
added
in flutter
DanTup
added a commit
to DanTup/devtools
that referenced
this pull request
Nov 8, 2023
…sidebar
For each unique platform type in the set of unsupported devices, this adds a new row ("Enable web for this project"). Clicking it triggers the same flow as VS Code (which currently involves a toast in the corner to confirm we can run `flutter create`).
In future we might want to change this prompt to be in the sidebar (so it's less likely you'll miss it).
Related PR for Dart-Code is at Dart-Code/Dart-Code#4831
See Dart-Code/Dart-Code#4820
See flutter#6563
DanTup
added a commit
to DanTup/devtools
that referenced
this pull request
Nov 9, 2023
…sidebar
For each unique platform type in the set of unsupported devices, this adds a new row ("Enable web for this project"). Clicking it triggers the same flow as VS Code (which currently involves a toast in the corner to confirm we can run `flutter create`).
In future we might want to change this prompt to be in the sidebar (so it's less likely you'll miss it).
Related PR for Dart-Code is at Dart-Code/Dart-Code#4831
See Dart-Code/Dart-Code#4820
See flutter#6563
DanTup
added a commit
to DanTup/devtools
that referenced
this pull request
Nov 9, 2023
…sidebar
For each unique platform type in the set of unsupported devices, this adds a new row ("Enable web for this project"). Clicking it triggers the same flow as VS Code (which currently involves a toast in the corner to confirm we can run `flutter create`).
In future we might want to change this prompt to be in the sidebar (so it's less likely you'll miss it).
Related PR for Dart-Code is at Dart-Code/Dart-Code#4831
See Dart-Code/Dart-Code#4820
See flutter#6563
DanTup
force-pushed
the
unsupported-devices-in-sidebar
branch
from
7a08f97 to
e5a17ae
Compare
DanTup
added a commit
to DanTup/devtools
that referenced
this pull request
Nov 9, 2023
…sidebar
For each unique platform type in the set of unsupported devices, this adds a new row ("Enable web for this project"). Clicking it triggers the same flow as VS Code (which currently involves a toast in the corner to confirm we can run `flutter create`).
In future we might want to change this prompt to be in the sidebar (so it's less likely you'll miss it).
Related PR for Dart-Code is at Dart-Code/Dart-Code#4831
See Dart-Code/Dart-Code#4820
See flutter#6563
+ add enablePlatformType method See #4820
DanTup
force-pushed
the
unsupported-devices-in-sidebar
branch
from
e5a17ae to
d0e85c0
Compare
DanTup
added a commit
to flutter/devtools
that referenced
this pull request
Nov 14, 2023
…sidebar (#6688) * Add the ability to enable platform types from the device list in the sidebar For each unique platform type in the set of unsupported devices, this adds a new row ("Enable web for this project"). Clicking it triggers the same flow as VS Code (which currently involves a toast in the corner to confirm we can run `flutter create`). In future we might want to change this prompt to be in the sidebar (so it's less likely you'll miss it). Related PR for Dart-Code is at Dart-Code/Dart-Code#4831 See Dart-Code/Dart-Code#4820 See #6563 * Tweak analytics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #4820