I have a change open at https://dart-review.googlesource.com/c/sdk/+/379303 that allows the server to accept a DTD URI and connect to it, exposing the shared LSP handlers.

I've also pushed a change here that adds a preview flag "dart.previewDtdLspIntegration": true that will call that method to establish this connection. To enable this without a flag in future we'll need to make some further server changes (to advertise that this is available), but we should have more testing before doing that.

When using Dart-Code and an SDK with those changes, you can see the LSP request registered over DTD (you need to streamListen for Service for ServiceRegistered and Lsp if you want the initialized event):

[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"dart/textDocument/augmentation"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"dart/textDocument/augmented"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"textDocument/codeLens"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"dart/textDocumentContent"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"textDocument/documentColor"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"textDocument/colorPresentation"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"textDocument/documentHighlight"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"textDocument/documentSymbol"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"textDocument/onTypeFormatting"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"textDocument/rangeFormatting"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"textDocument/formatting"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"textDocument/hover"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"textDocument/implementation"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"callHierarchy/incomingCalls"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"callHierarchy/outgoingCalls"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"textDocument/prepareCallHierarchy"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"textDocument/prepareTypeHierarchy"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"textDocument/signatureHelp"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"dart/textDocument/super"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"textDocument/typeDefinition"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"typeHierarchy/subtypes"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"typeHierarchy/supertypes"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"workspace/willRenameFiles"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","eventKind":"ServiceRegistered","eventData":{"service":"Lsp","method":"workspace/symbol"},"timestamp":1724248142408}}
[2:49:02 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Lsp","eventKind":"initialized","eventData":{},"timestamp":1724248142441}}

You can then call these methods over DTD:

[2:49:11 PM] [DartToolingDaemon] [Info] ==> {"id":"1234","jsonrpc":"2.0","method":"Lsp.textDocument/hover","params":{"position":{"line":1,"character":2},"textDocument":{"uri":"file:///C:/Dev/Dart-Code/Dart-Code/src/test/test_projects/hello_world/lib/deferred_script.dart"}}}
[2:49:12 PM] [DartToolingDaemon] [Info] <== {"jsonrpc":"2.0","result":{"type":"Hover","result":{"contents":{"kind":"markdown","value":"```dart\nvoid print(Object? object)\n```\nType: `void Function(Object?)`\n\n*dart:core*\n\n---\nPrints an object to the console.\n\nOn the web, `object` is converted to a string and that string is output to\nthe web console using `console.log`.\n\nOn native (non-Web) platforms, `object` is converted to a string and that\nstring is terminated by a line feed (`'\\n'`, U+000A) and written to\n`stdout`. On Windows, the terminating line feed, and any line feeds in the\nstring representation of `object`, are output using the Windows line\nterminator sequence of (`'\\r\\n'`, U+000D + U+000A).\n\nCalls to `print` can be intercepted by [Zone.print]."},"range":{"end":{"character":7,"line":1},"start":{"character":2,"line":1}}}},"id":"1234"}

There's still more to do (such as scheduling in the server, and figuring out how client capabilities should be handled), but it's hopefully near a point that other development can be started against it (using the preview flags).

Provide DTD address to analysis server #5090

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions