Support updating the theme in embedded DevTools#5297
Merged
Conversation
DanTup
added
is enhancement
DanTup
added a commit
to DanTup/devtools
that referenced
this pull request
Oct 2, 2024
This extracts the code that updates the theme (to `_updateTheme`) and then calls it in response to either a DTD event or a postMessage event. Fixes Dart-Code/Dart-Code#5297
This was referenced Oct 2, 2024
DanTup
force-pushed
the
devtools-theme-update
branch
from
570ead5 to
57ab7a1
Compare
+ update sidebar to use the same mechanism + remove hashes from colors in URLs to workaround Flutter issue + remove some unused variables Fixes #4971
Member
Author
|
Verified on current Flutter beta. theme.mp4 |
DanTup
force-pushed
the
devtools-theme-update
branch
from
57ab7a1 to
b6dfbae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires an equiv DevTools change to land before it'll work (this can ship, it just won't work until DevTools is listening for the postMessage events).
devtools_color_theme_update.mp4
The corresponding DevTools work is at flutter/devtools#8387.
Fixes #4971