-
Notifications
You must be signed in to change notification settings - Fork 344
Closed
Labels
is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.
Milestone
Description
For dart-lang/sdk#60259, we have two options:
- Request the whole
editorconfiguration and just read the values we care about - Request only the values we care about individually (
editor.formatOnSave,editor.codeActionsOnSaveetc.)
The first one results in all of the editor settings be included in the payload (once for global, once for each workspace folder) which isn't terrible, but also means this shows up in instrumentation logs (where it didn't before).
The second seems better, however it currently fails because we have middleware to set enableSnippets that assumes that the only configuration we ever provide is an object (eg. the dart section). When requesting editor.formatOnSave, we'll try to set a field named enableSnippets on a boolean and fail.
We should fix the middleware to be more tolerant of other settings being added in future.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.