Provide server with useful diagnostic values to include in exportable reports#5458
Merged
Provide server with useful diagnostic values to include in exportable reports#5458
Conversation
… reports Sent once the server has started, and also if any config change affects any of the interesting sections (currently "dart" and "editor"). Config is scoped to Dart-specific config (falling back to defaults if no Dart-specific config is set).
pq
approved these changes
Mar 26, 2025
|
Looks like a great start. Thank you! |
bwilkerson
approved these changes
Mar 26, 2025
bwilkerson
left a comment
There was a problem hiding this comment.
That output looks good to me too.
…s/refactors are available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are sent once the server has started, and also if any config change affects any of the interesting sections (which are currently "dart" and "editor"). The reported config is scoped to Dart config (falling back to defaults if no Dart-specific config is set), which means we can't tell if someone has
formatOnSaveset to something different for YAML files (for example), but if becomes useful, we could split this out to record multiple languages values.This info is visible in the analyzer diagnostics pages as well as the exported report. For a sample workspace it looks like this:
For a single-root workspace, only the
globalsection would be present. For a multi-root workspace, we'll addfolder_xsections for any workspace folder that has settings that differ from the global one.@bwilkerson @pq the settings included for now are below - let me know if you think there's anything else we should include (we can ofc update this over time). Additionally, I've included the "hostKind", which is a string that helps identify the environment being run in (for example Docker, WSL, Codespaces, or just native VS Code desktop).