Register/unregister VM Services with DTD#5527
Merged
Conversation
DanTup
added
is enhancement
DanTup
force-pushed
the
register-vm-service
branch
from
c463d4d to
a5ba774
Compare
We can't subscribe to the Service stream in the test because we now do it in the daemon class always.
DanTup
force-pushed
the
register-vm-service
branch
from
b10e487 to
33147c7
Compare
Member
Author
|
@kenzieschmoll FYI, I landed this change but haven't yet published a pre-release version with it in. If it'd be useful for anyone, I can push one though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DartCapabilitiesaccordingly (this is only used to gate tests)getVmServiceUris(which will now begetVmServices)Fixes #5526