Conversation
DanTup
added
is enhancement
|
/gemini review |
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for using the flutter-dev script instead of the standard flutter tool. This is a useful feature for developers working on the Flutter tool itself. The implementation introduces a new setting dart.useFlutterDev and uses it to select the correct executable.
The changes are straightforward and look good. I have one suggestion in src/shared/constants.ts to improve code clarity by reordering the declaration of flutterPath and its modifier function setFlutterDev.
Overall, this is a solid contribution.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for using flutter-dev instead of the standard flutter command, addressing issue #5651. The flutter-dev script is intended for developers of the Flutter tool itself to run from source code.
- Adds a new configuration option
dart.useFlutterDevto toggle betweenflutterandflutter-devexecutables - Implements a dynamic path switching mechanism that modifies the Flutter path at runtime
- Configures the Flutter development mode during extension activation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/shared/constants.ts | Adds flutterDev executable definitions and dynamic path switching logic |
| src/extension/extension.ts | Imports and calls the Flutter dev configuration during activation |
| src/extension/config.ts | Adds the useFlutterDev configuration property |
| package.json | Defines the new dart.useFlutterDev VS Code setting |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Fixes #5651