Conversation
…ng to activate See #5837
This is one of the top reasons for an extension restart.
…ers a restart In the past we had a lot of failed startups because flags intended for `flutter run` were added to `flutterAdditionalArgs` and passed here (instead of going in `flutterRunAdditionalArgs`). This will help identify if that's happening here without leaking those args.
DanTup
added
the
is enhancement
|
@codex review /gemini review |
|
To use Codex here, create a Codex account and connect to github. |
|
Thanks for invoking |
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
There was a problem hiding this comment.
Pull request overview
This PR adds prompts to encourage users to file bug reports for two scenarios that indicate potential issues: Flutter daemon terminations and SDK path changes during startup.
Key Changes:
- Upgraded Flutter daemon termination notifications from info to warning level with explicit bug filing instructions
- Added detection for SDK path changes within 1 second of startup, prompting users to file bugs about this performance-impacting behavior
- Tracked whether the Flutter daemon spawned with additional arguments to provide better diagnostic context
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/extension/flutter/flutter_daemon.ts | Added tracking of additional args at spawn time, upgraded termination prompt to warning severity with explicit bug filing request, and included additional args status in restart data |
| src/extension/extension.ts | Added import for os and showLogAction, fixed spelling error in comment, and implemented SDK path change detection during startup with user prompt to file bugs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Please file an issue at https://github.com/Dart-Code/Dart-Code/issues/new?template=BLANK_ISSUE&title=SDK%20path%20changed%20during%20startup | ||
|
|
||
| ${ringLogContents.split("\n").filter((l) => l.includes("[General]") || l.includes("[Warn]") || l.includes("[Error]")).join("\n")} | ||
| `.trim(); |
There was a problem hiding this comment.
The logContents string has inconsistent indentation. The template literal starts with proper indentation, but the body content has excessive leading whitespace that will be preserved in the output. This makes the log file harder to read and looks unprofessional.
| `.trim(); | |
| `.trim(); |
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
This adds/tweaks prompts to encourage users to file bugs for: