Mark suites as queued when run outside of the test runner#5932
Mark suites as queued when run outside of the test runner#5932
Conversation
DanTup
added
is enhancement
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![chatgpt-codex-connector[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ted through the test runner
|
@codex review /gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces functionality to correctly mark test suites as queued when they are run outside of the VS Code test runner UI. The changes involve refactoring the registerTestRun method to explicitly track whether a test run was initiated by the test runner, updating the testRuns data structure, and adjusting the logic for ending debug sessions and enqueuing tests. A new suiteStarted event has been added to the test model and controller to handle the specific case of suites being discovered during an active test run, ensuring proper state management for tests not started via the UI. Additionally, the markEnqueued method has been refined to prevent setup/teardown tests from being explicitly enqueued, which improves the accuracy of the test UI representation.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4d9d503e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
DanTup
deleted the
mark-suites-run-outside-of-test-explorer-as-queued
branch
Fixes #5928