Improve performance of test discovery in large projects#5937
Merged
Conversation
… of the project This will be much faster for Pub Workspaces
…lude the word "flutter" This will be slightly slower if Flutter _is_ referenced, but _way_ faster if it's not.
This can remove hundreds of duplicate checks on the pubspec.yaml during test discovery
…of searching again
DanTup
added
in testing
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5937 +/- ##
=======================================
Coverage 67.60% 67.60%
=======================================
Files 169 169
Lines 12992 13014 +22
Branches 2572 2577 +5
=======================================
+ Hits 8783 8798 +15
- Misses 3750 3755 +5
- Partials 459 461 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the
pkgfolder in SDK, this gets down from around 9.4s to around 1.3s on my machine.I can't currently test the whole SDK due to #5936