Adds a Run All Skipped Tests command#3090
Merged
DanTup merged 1 commit intoDart-Code:masterfrom Jan 23, 2021
BootBlock:run-skipped-tests
Merged
Adds a Run All Skipped Tests command#3090DanTup merged 1 commit intoDart-Code:masterfrom BootBlock:run-skipped-tests
DanTup merged 1 commit intoDart-Code:masterfrom
BootBlock:run-skipped-tests
Conversation
DanTup
approved these changes
Jan 22, 2021
Comment on lines
+371
to
+372
| // Get the expected tree and filter it to only skipped tests. | ||
| // const expectedResults = getExpectedResults().split("\n").filter((l) => l.includes("skip.svg")).join("\n"); |
Member
There was a problem hiding this comment.
This comment is out of date, and the commented code can be removed. I presume the expectedResults variable below is to account for differences when running skipped tests from the normal expected results embedded in the file.
DanTup
added
in commands
Member
|
@BootBlock I merged this and addressed the nits in 81f9a87. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3048.