Skip to content

Use Telemetry v1.75 VSCode API #4457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanTup merged 20 commits into from Mar 29, 2023
Merged

Use Telemetry v1.75 VSCode API #4457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
8a98f9b
Bump minimum VSCode API to 1.75
Mar 11, 2023
c6b2fc8
Start transitioning to TelemetryLogger VSCode API. @DanTup
Mar 23, 2023
2c68832
Moves telemetry logic to new class `GoogleAnalyticsTelemetrySender` a…
Mar 24, 2023
d98c84c
Return softly without throwing an exception in sendErrorData
Mar 27, 2023
920c9b7
Simplify sendEventData method so it only sends data and nothing more
Mar 27, 2023
4f155fc
Restore event method in `Analytics` class
Mar 27, 2023
5a68395
Remove `handleError` method
Mar 27, 2023
72fd528
Remove `logDebuggerRestart` and `logDebuggerHotReload`
Mar 27, 2023
149c57a
Remove `logError` and `time` methods
Mar 27, 2023
8a58c56
Restore `handleError`
Mar 27, 2023
e6067bc
Fix typo where `telemetryLogger.info` was being used instead of `logg…
Mar 27, 2023
5d9ac23
Add `readonly` to logger and workspaceContext
Mar 27, 2023
947bb4c
Check if data is null on sendEventData (to avoid 1 billion dollar issue)
Mar 28, 2023
ca0f790
Use more concrete type for send method on GoogleAnalyticsTelemetrySender
Mar 28, 2023
d33918c
Avoid use of try/catch on send (GoogleAnalyticsTelemetrySender)
Mar 28, 2023
ea92668
Fix calls to this.event on Analytcs
Mar 28, 2023
17834d7
Pass needed arguments to GoogleAnalyticsTelemetrySender
Mar 28, 2023
e327ec1
Remove calls to deprecated methods on `Analytics`
Mar 28, 2023
631bdc2
Add constructor to class `GoogleAnalyticsTelemetrySender`
Mar 29, 2023
43e7a9f
Annex globalData (previously was `data` in `send` method)
Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"version": "3.62.0-dev",
"publisher": "Dart-Code",
"engines": {
"vscode": "^1.67.0"
"vscode": "^1.75.0"
},
"extensionKind": [
"workspace"
Expand Down Expand Up @@ -2881,7 +2881,7 @@
"@types/node": "^16.18.11",
"@types/semver": "^7.3.13",
"@types/sinon": "5.0.5",
"@types/vscode": "^1.67.0",
"@types/vscode": "^1.75.0",
"@types/ws": "^8.5.4",
"@typescript-eslint/eslint-plugin": "^5.48.0",
"@typescript-eslint/eslint-plugin-tslint": "^5.48.0",
Expand Down
1 change: 0 additions & 1 deletion src/extension/analysis/analyzer_status_reporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ export class AnalyzerStatusReporter {
if (error.stackTrace)
this.logger.error(error.stackTrace, LogCategory.Analyzer);

this.analytics.logError(`Analyzer server error${method ? ` (${method})` : ""}`, error.isFatal);

errorCount++;

Expand Down
Loading