Update background task patterns for build_runner 2.5.0#5572
Update background task patterns for build_runner 2.5.0#5572DanTup merged 1 commit intoDart-Code:masterfrom
Conversation
mernen
force-pushed
the
build-runner-problem-matchers
branch
from
02ae54c to
abc728f
Compare
mernen
changed the title
mernen
force-pushed
the
build-runner-problem-matchers
branch
from
abc728f to
eaa3bb0
Compare
Unfortunately so. A lot of VS Code can't be automated through the basic APIs, so it'd need something like Playwright for real e2e tests (something that would be nice to set up for a few things, but hasn't so far been enough to justify the work). Have you verified this manually that it's detecting the stop/start as expected?
Depending on when the format changes, it probably wouldn't be a bad idea to support the new version without the old version if both can't be supported, though I'm not sure it's that important - it's possible in future we'll revisit this integration anyway because there's been more work going into build_runner now Macros is gone (see dart-lang/build#3806). |
Yes. (I haven't tried running the modified extension directly, but I did place this matcher in a project's |
DanTup
added
the
in tasks
|
Perfect, thank you! |
DanTup
added
the
is enhancement
2 participants
build_runnerv2.5.0 changed the output format. The relevant new messages are:Starting new build:
https://github.com/dart-lang/build/blob/8f9939f3c804edb91d4df33045536f6894472af0/build_runner_core/lib/src/logging/build_log.dart#L388-L390
Success/failure:
https://github.com/dart-lang/build/blob/8f9939f3c804edb91d4df33045536f6894472af0/build_runner_core/lib/src/logging/build_log.dart#L58-L62C41
The old background patterns are kept, since projects may keep using older versions of
build_runnerfor a long while. I don't expect them to interfere with each other.(As far as I can tell, there are no tests for problem matchers?)
Also: I didn't change the problem matchers, only the background ones. I don't think it's possible to build a single matcher that works with both old and new outputs, and even if we were to have two separate
problemMatchers, I'm not sure if the output can be properly described, since error messages are often multiline.AFAIK the only consequence of outdated problem matchers is that we don't offer build errors in the Problems pane, whereas having outdated background matchers means
preLaunchTasks never finish and launch operations get stuck.