Add support for showing app warnings from Flutter#5749
Conversation
Starting with the slow iOS wireless debugging warning. Fixes #5730
DanTup
added
is enhancement
|
@codex review |
There was a problem hiding this comment.
Pull Request Overview
Adds UI support for showing app-issued warnings from Flutter debug sessions, starting with the iOS wireless debugging performance warning. Persists “Don’t Show Again” per-warning suppression in global state.
- Handle new debug event "app.warning" to display a VS Code warning with optional “More Info” link
- Add "Don't Show Again" action and persist per-warning suppression via globalState
- Introduce context getters/setters for app warning suppression
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/shared/vscode/workspace.ts | Adds getters/setters to persist “don’t show again” flags for app warnings. |
| src/shared/constants.ts | Introduces new action label doNotShowAgainAction. |
| src/extension/commands/debug.ts | Handles "app.warning" event: shows a warning, opens optional URL, and persists “Don’t Show Again”. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for displaying application warnings from Flutter within VS Code. The changes are well-structured, introducing a new event handler for app.warning, a constant for the 'Don't Show Again' action, and context methods to persist user preferences. My review includes a suggestion to improve the robustness of the new event handler by adding validation for incoming data and enhancing error logging.
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting |
Starting with the slow iOS wireless debugging warning.
Fixes #5730