@codex review
/gemini review

Hello @DanTup,

Thank you for invoking a code review! I've thoroughly examined your pull request titled "Switch "pub run" for "dart run" in tasks".

Overall Impression:

This is a well-executed and important change that aligns with the evolution of the Dart SDK's command-line tools. The refactoring to explicitly use dart run for build_runner tasks and to streamline the createPubTask method is clean and improves clarity. The addition of comprehensive tests for both Dart and Flutter projects, including the verification of FLUTTER_ROOT for Flutter tasks, is excellent and ensures the robustness of this change.

Detailed Review:

• src/extension/dart/dart_task_provider.ts

  • The removal of "pub" from the taskOptions array for build_runner tasks (Diff 1) correctly reflects the shift to dart run.
  • The direct calls to this.createTask(workspaceFolder, projectFolder, "dart", [...]) for build_runner tasks (Diff 2) are the core of this change and are implemented correctly.
  • The simplification of createPubTask (Diff 3) to always prepend "pub" is a good refactoring. It clarifies the purpose of createPubTask as being specifically for pub commands, while build_runner tasks now correctly bypass it to use dart run directly.

• src/test/dart/commands/dart_tasks.test.ts

  • The new test case it("includes build_runner tasks that use 'dart run'", ...) (Diff 2) is crucial for verifying the intended behavior. It correctly asserts the executable and arguments for the build_runner task.

• src/test/flutter/commands/flutter_tasks.test.ts

  • The addition of this new test file and the corresponding test case it("includes build_runner tasks that use 'dart run' and have FLUTTER_ROOT", ...) (Diff 1) is highly valuable. It ensures that the changes are also correctly applied to Flutter projects and, importantly, verifies that the FLUTTER_ROOT environment variable is set, which is essential for Flutter tool execution.

Conclusion:

All changes are correct, well-tested, and improve the maintainability of the codebase by aligning with current best practices for Dart/Flutter command execution. I recommend approving this pull request.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.27%. Comparing base (1a85e1e) to head (1e5ceda).
⚠️ Report is 4 commits behind head on master.

@@            Coverage Diff             @@
##           master    #5882      +/-   ##
==========================================
- Coverage   67.32%   67.27%   -0.05%     
==========================================
  Files         168      168              
  Lines       12894    12894              
  Branches     2554     2554              
==========================================
- Hits         8681     8675       -6     
- Misses       3762     3765       +3     
- Partials      451      454       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.