Requires the SimpleDFD PR in DataFlowAnalysis to be merged first

Requires DataFlowAnalysis/DataFlowAnalysis#209 to be merged first

@Nicolas-Boltz @uuqjz
Ready to merge.

@uuqjz your changes from fix-web-converter are in. But this also means multi flow into one input pin wont work until the delimiter is changed in the WebEditor. I'm currently working on that but not 100% sure whether I can do it

^^
I managed to do it: DataFlowAnalysis/WebEditor#46

If you look at #193 we wanted to use a pipe as delimiter

This PR lacks any testing regarding the new features.
As this commit changes how behavior is parsed and how flow names are dealt with, i really think we should do a complex test json now to validate correct conversion.

I am currently working on the tests for the changes and ran into an issue that makes me question how much sense it makes to continue work on the converter without adjusting the WebEditor Assignment creation.

The behavior string "set TypeA.ValueA = a2d.TypeA.ValueA && b2d|c2d.TypeA.ValueA" is a valid string in the WebEditor. It describes sending out the ValueA label if and only if it arrives on both the a2d and b2d|c2d Input pins.
To create this behavior in the MetaModel one would have to create 3 Assignments.

• One that sets the label to true should it arrive on one of the two pins.
• And two that set the label to false should it arrive on only one pin but not the other.

With more complex behavior strings this gets even worse.

I suggest changing the webEditor behavior strings to something like:

• Assignment({inputPins}, Term, {outLabels})
• ForwardingAssignment({inputPins})
  short term and then add a creation wizard long term.

This would make MetaModel and WebEditor semantically equivalent too

I suggest changing the webEditor behavior strings to something like:

* Assignment({inputPins}, Term, {outLabels})

* ForwardingAssignment({inputPins})
  short term and then add a creation wizard long term.

This would make MetaModel and WebEditor semantically equivalent too

We should discuss that in the next dfa meeting.

• Assignment({inputPins}, Term, {outLabels})

• Forwarding({inputPins})

  These changes have now been implemented and the tests adjusted. I will add some tests for the annotation creation then
  it will be ready to merge.

@uuqjz @Nicolas-Boltz Tests for annotations have been added. Ready for review

@uuqjz @Nicolas-Boltz Tests for annotations have been added. Ready for review

Does the new minimal.json contain every legal thing in the webeditor?
Eg. forwarding multiple flows from required and optional pins

So we can now, if the webconverter finally behaves as intended?

Could you add some complexer terms that use labels to the minimal json?
The most complex one you use is TRUE || FALSE

Could you add some complexer terms that use labels to the minimal json?
The most complex one you use is TRUE || FALSE

Sure, but complex terms are already tested in the Behaviour Test.

Could you add some complexer terms that use labels to the minimal json?
The most complex one you use is TRUE || FALSE

Sure, but complex terms are already tested in the Behaviour Test.

Done @uuqjz

@01Parzival10 Please resolve conflicts and merge