Conversation
Entenwilli
added
enhancement
Nicolas-Boltz
left a comment
Nicolas-Boltz
left a comment
There was a problem hiding this comment.
Some minor things. I really like this implementation and version we are currently getting to!
...lysis.analysis.dfd/src/org/dataflowanalysis/analysis/dfd/core/DFDPartialFlowGraphFinder.java
Outdated
Show resolved
Hide resolved
.../org.dataflowanalysis.analysis.dfd/src/org/dataflowanalysis/analysis/dfd/core/DFDVertex.java
Outdated
Show resolved
Hide resolved
...s.analysis.pcm/src/org/dataflowanalysis/analysis/pcm/PCMDataFlowConfidentialityAnalysis.java
Outdated
Show resolved
Hide resolved
...lysis.analysis.pcm/src/org/dataflowanalysis/analysis/pcm/core/PCMPartialFlowGraphFinder.java
Outdated
Show resolved
Hide resolved
...lysis.analysis.pcm/src/org/dataflowanalysis/analysis/pcm/core/finder/PCMSEFFFinderUtils.java
Outdated
Show resolved
Hide resolved
...alysis.analysis.pcm/src/org/dataflowanalysis/analysis/pcm/core/finder/SEFFFinderContext.java
Outdated
Show resolved
Hide resolved
...lysis.analysis.pcm/src/org/dataflowanalysis/analysis/pcm/core/user/CallingUserPCMVertex.java
Outdated
Show resolved
Hide resolved
sebinside
left a comment
sebinside
left a comment
There was a problem hiding this comment.
Thank you for this joint effort and the great implementation of FlowGraphs! I like the result very much and only have minor comments that should be easy to fix. Regarding the functionality, the implementation is exactly what we had in mind, and the complexity is greatly reduced while unifying the approach for both DFD and PCM. Thank you!
Maybe as final questions: If I retrieve two FlowGraphs via findFlowGraph, I can evaluate them completely on their own without interference, right? And the same even applies to partial flow graphs, so that I could e.g., alter or clone them prior to the evaluation without interference?
.../org.dataflowanalysis.analysis.dfd/src/org/dataflowanalysis/analysis/dfd/core/DFDVertex.java
Show resolved
Hide resolved
...s.analysis.pcm/src/org/dataflowanalysis/analysis/pcm/PCMDataFlowConfidentialityAnalysis.java
Outdated
Show resolved
Hide resolved
...lysis.analysis.pcm/src/org/dataflowanalysis/analysis/pcm/core/PCMPartialFlowGraphFinder.java
Outdated
Show resolved
Hide resolved
...lysis.pcm/src/org/dataflowanalysis/analysis/pcm/core/PCMVertexCharacteristicsCalculator.java
Outdated
Show resolved
Hide resolved
...les/org.dataflowanalysis.analysis/src/org/dataflowanalysis/analysis/core/AbstractVertex.java
Outdated
Show resolved
Hide resolved
...les/org.dataflowanalysis.analysis/src/org/dataflowanalysis/analysis/core/AbstractVertex.java
Outdated
Show resolved
Hide resolved
...les/org.dataflowanalysis.analysis/src/org/dataflowanalysis/analysis/core/AbstractVertex.java
Outdated
Show resolved
Hide resolved
...lysis.analysis.dfd/src/org/dataflowanalysis/analysis/dfd/core/DFDPartialFlowGraphFinder.java
Outdated
Show resolved
Hide resolved
|
@Entenwilli @01Parzival10 The reviews are in and the good news: Only minor things. Now it's on you again, let's try to merge this PR next week! |
…though the analysis
|
The requested changes are now implemented. I've left two conversations open for some feedback |
|
Looks promising, I think the remaining points can be discussed independently from this PR. I will have a final look and merge this PR tomorrow! |
4 participants
This PR implements flow graphs for the data flow analysis. It contains the following:
previousElementsfrom AbstractVertex and add to DFD and PCM Variantequalsmethod for referenced elements (e.g. Calling/Returning for PCM Elements)This PR closes #17, #60, #67, #93 and #100