Conversation
Entenwilli
added
enhancement
Member
|
#123 has been merged, @Entenwilli please rebase this PR so we can also merge it |
Member
Author
|
@sebinside This branch is now fully up-to-date |
sebinside
reviewed
Mar 4, 2024
Member
sebinside
left a comment
sebinside
left a comment
There was a problem hiding this comment.
Would it be possible to move the common code of the DFD analysis and the PCM analysis to the abstract parent class?
Member
Author
|
Yep, this is (now) implemented in 6f6e383 @sebinside |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR is dependent on #123 and thus needs to be merged afterwards
This PR adds unified logging for both analyses in this repo. The proposed logging format is:
An example would be:
This PR closes #126