Converter for various DFD formats#128
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
sebinside
left a comment
There was a problem hiding this comment.
Here is my initial review regarding code quality. I have to test around more to say something about the correctness of all transformations.
...alysis.converter.tests/src/org/dataflowanalysis/analysis/converter/tests/ConverterTests.java
Outdated
Show resolved
Hide resolved
...rg.dataflowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/Main.java
Outdated
Show resolved
Hide resolved
...rg.dataflowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/Main.java
Outdated
Show resolved
Hide resolved
...rg.dataflowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/Main.java
Outdated
Show resolved
Hide resolved
...alysis.converter.tests/src/org/dataflowanalysis/analysis/converter/tests/ConverterTests.java
Outdated
Show resolved
Hide resolved
...alysis.converter.tests/src/org/dataflowanalysis/analysis/converter/tests/ConverterTests.java
Outdated
Show resolved
Hide resolved
...alysis.converter.tests/src/org/dataflowanalysis/analysis/converter/tests/ConverterTests.java
Outdated
Show resolved
Hide resolved
...alysis.converter.tests/src/org/dataflowanalysis/analysis/converter/tests/ConverterTests.java
Outdated
Show resolved
Hide resolved
...alysis.converter.tests/src/org/dataflowanalysis/analysis/converter/tests/ConverterTests.java
Outdated
Show resolved
Hide resolved
Entenwilli
left a comment
There was a problem hiding this comment.
Some more comments about code quality and maintainability. So far, the output from ASs to DFD looks correct. The other transformations have not been tested by me so far
bundles/org.dataflowanalysis.analysis.converter/META-INF/MANIFEST.MF
Outdated
Show resolved
Hide resolved
...aflowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/ProcessASS.java
Outdated
Show resolved
Hide resolved
...aflowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/ProcessASS.java
Outdated
Show resolved
Hide resolved
...flowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/ProcessJSON.java
Outdated
Show resolved
Hide resolved
...lowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/webdfd/Model.java
Outdated
Show resolved
Hide resolved
...verter/src/org/dataflowanalysis/analysis/converter/microsecend/TaggedValuesDeserializer.java
Show resolved
Hide resolved
...rg.dataflowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/Main.java
Outdated
Show resolved
Hide resolved
...aflowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/ProcessASS.java
Outdated
Show resolved
Hide resolved
...aflowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/ProcessASS.java
Outdated
Show resolved
Hide resolved
...flowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/ProcessJSON.java
Outdated
Show resolved
Hide resolved
|
Thank you all for the great feedback and discussion, I think once @uuqjz implemented all required changes this will be a valuable and maintainable addition to the data flow analysis! |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
Entenwilli
left a comment
There was a problem hiding this comment.
Some more code style changes. Furthermore, most methods are currently undocumented (I know, there are some in the analysis as well, those will be fixed in #123)
...taflowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/Converter.java
Outdated
Show resolved
Hide resolved
...taflowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/Converter.java
Outdated
Show resolved
Hide resolved
...taflowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/Converter.java
Outdated
Show resolved
Hide resolved
...taflowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/Converter.java
Outdated
Show resolved
Hide resolved
...aflowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/ProcessASS.java
Outdated
Show resolved
Hide resolved
...flowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/ProcessJSON.java
Outdated
Show resolved
Hide resolved
...verter/src/org/dataflowanalysis/analysis/converter/microsecend/TaggedValuesDeserializer.java
Outdated
Show resolved
Hide resolved
...flowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/ProcessJSON.java
Outdated
Show resolved
Hide resolved
...flowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/ProcessJSON.java
Outdated
Show resolved
Hide resolved
...flowanalysis.analysis.converter/src/org/dataflowanalysis/analysis/converter/ProcessJSON.java
Outdated
Show resolved
Hide resolved
|
@sebinside @Nicolas-Boltz @Entenwilli |
|
I have no idea why the build test fail |
bundles/org.dataflowanalysis.analysis.converter/META-INF/MANIFEST.MF
Outdated
Show resolved
Hide resolved
* Build Jackson Parser for MicroSecEnd dataset * print information flows * Added DFD to xml writer * Added Producer * Create Processes and External Entities from Classes * Process all JSON files * Flow record for storing flows * Added Behaviour and Pins * Modeled WebDFD * Removed unused record * Changed node to child * Create WebDFD nodes, flows and ports from dfd * New JSONs * Added WebDFD to DFD supporting nodes, edges and ports * Merged main methods * Renamed classes * Removed unused files * Refactored packages * Removed SimpleFlow * Ignore unnecessary field in Web Json * First version with label labeltypes and assignments * Functional Micro -> DFD -> Web * Fixed node properties * Cleaned code a bit * Correctly parse and create forward assignment from Web * Create normal behavior from dfd * Ignore test files * For real now * Added syntactic sugar * Plant UML to DFD * Assure Web=conv(conv(Web)) * Tidy test * Refactored equals logic * Test and fix converter.py * Cleanup after tests * Test Micro -> DFD * First ass to dfd converter * Fixed warnings * Ass tests and perserve Id * Test ass flows * Refactored test file structure * Changed main * Ready for PR * Added header to python script * Moved test and models * Refactored Main to Converter without static methods * Tidied Converter * Changes * Revert Readme * Improved converter interfaces * Split converter in convert function that return objects and storing functionality, converter can now be used with either files or objects * Storing test * Fixed EMF warning * FIxed ass warnings * Before Pull from Felix * fix(ass-converter): fix unchecked cast warnings * Removed Catch from Test * Made TVD less fishy * Small improvements * Empty gitingore * JPlag formatter applied * Loading functionality + enhanced tests * Streamlined converter * Cleanup * Dedicated sorting methods * Minor stuff * Maming * Made Process super class * Forgot add * mvn dependancy * Split tests by model * Bunch of small renamings * Split converter by models * Split up long methods * Split up converter api in subconverts * Made internal methods private * Comments * Paths get were practical * Made interfaces better * Regex for behavior * Format for Review * Small stuff * Added logic converter * Replace behavior to term and vice versa with custom parser * Making parsing of logic neater * More streams * More palladio stuff * Placeholder * Felix I * Felix II * Whitespace dependencies * Request from Nicolas and JavaDoc * Integrated FlowGraphs into Converter * Format * Test manual conversion * Sebastian I * Sebastian II * Preserve behavior and pin names + tests * JavaDoc * Adapted test for optional inputs * EOF * Fixed DFD loadinh * Magic string * Camera ready * Now? * Please * Ternary * Camera ready II * Moved comment to disabled test * Store test models locally * Unused import * Removed junit --------- Co-authored-by: Felix Schwickerath <[email protected]>
This converter provides the means to convert:
WebDFD -> DFD
DFD -> WebDFD
MicroSecEndJson -> DFD
MicroSedEndPlant -> DFD
ASs -> DFD