Skip to content

Provide unified copying of PFGs and more query methods in Vertices#135

Merged
sebinside merged 12 commits intomainfrom
flowgraph-additions
Apr 9, 2024
Merged

Provide unified copying of PFGs and more query methods in Vertices#135
sebinside merged 12 commits intomainfrom
flowgraph-additions

Conversation

@Entenwilli
Copy link
Member

This PR adds the methods and changes outlined in #130:

  • Add unified Interface for copying partial flow graphs
  • Add query methods for node characteristics and data flow variables (for both strings and the actual objects)

This PR closes issue #130

@Entenwilli Entenwilli added enhancement New feature or request core Related to the core DFD/PCM data flow analysis labels Mar 12, 2024
@Entenwilli Entenwilli added this to the 2.0.0 milestone Mar 12, 2024
@Entenwilli Entenwilli self-assigned this Mar 12, 2024
Copy link
Member

@Nicolas-Boltz Nicolas-Boltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, please look if it occurs some place else and fix ist also

@Entenwilli Entenwilli requested a review from Nicolas-Boltz April 2, 2024 08:05
Copy link
Member

@Nicolas-Boltz Nicolas-Boltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Itsy Bitsy Teenie Weenie Yellow wrong variable namey

@Entenwilli Entenwilli force-pushed the flowgraph-additions branch from 0b42930 to 6509eb6 Compare April 3, 2024 11:36
@Entenwilli Entenwilli requested a review from Nicolas-Boltz April 3, 2024 12:45
@Entenwilli Entenwilli force-pushed the flowgraph-additions branch from 6509eb6 to 9fcb51d Compare April 3, 2024 13:09
@Entenwilli
Copy link
Member Author

After this PR, the milestone for 2.0 is almost complete. @Nicolas-Boltz would you create a new release afterward (with products attached)?

@Entenwilli Entenwilli force-pushed the flowgraph-additions branch from 9fcb51d to cd6b385 Compare April 4, 2024 18:42
Copy link
Member

@Nicolas-Boltz Nicolas-Boltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebinside sebinside merged commit debe204 into main Apr 9, 2024
@sebinside sebinside deleted the flowgraph-additions branch April 9, 2024 10:28
Nicolas-Boltz pushed a commit that referenced this pull request May 28, 2025
Provide unified copying of PFGs and more query methods in Vertices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Related to the core DFD/PCM data flow analysis enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants