Skip to content

Implement changes/additions required for extending the analysis#138

Merged
sebinside merged 6 commits intomainfrom
abunai-changes
Apr 4, 2024
Merged

Implement changes/additions required for extending the analysis#138
sebinside merged 6 commits intomainfrom
abunai-changes

Conversation

@Entenwilli
Copy link
Member

This PR contains all the proposed changes I have encountered during my implementation of the uncertainty-aware analysis

@Entenwilli Entenwilli added enhancement New feature or request research Investigation or reserach related issue core Related to the core DFD/PCM data flow analysis labels Mar 15, 2024
@Entenwilli Entenwilli self-assigned this Mar 15, 2024
@Entenwilli Entenwilli added this to the 2.0.0 milestone Apr 3, 2024
@Entenwilli Entenwilli marked this pull request as ready for review April 3, 2024 13:20
Copy link
Member

@sebinside sebinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between FlowGraph, TransposeFlowGraph, and FlowGraphCollection? I understand the latter ones but I don't understand why these FlowGraph classes are additionally required. They look similar to the collection classes to me.

@Entenwilli
Copy link
Member Author

What is the difference between FlowGraph, TransposeFlowGraph, and FlowGraphCollection? I understand the latter ones but I don't understand why these FlowGraph classes are additionally required. They look similar to the collection classes to me.

Those were duplicate classes I forgot to remove during my rebase

@Entenwilli Entenwilli requested a review from sebinside April 3, 2024 19:02
Copy link
Member

@sebinside sebinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGNTM

@sebinside sebinside merged commit a016503 into main Apr 4, 2024
@sebinside sebinside deleted the abunai-changes branch April 4, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Related to the core DFD/PCM data flow analysis enhancement New feature or request research Investigation or reserach related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants