Skip to content

Rename Flow Graph Classes#141

Merged
sebinside merged 6 commits intomainfrom
paper-renaming
Apr 3, 2024
Merged

Rename Flow Graph Classes#141
sebinside merged 6 commits intomainfrom
paper-renaming

Conversation

@Entenwilli
Copy link
Member

This PR renames the Flow Graph Classes:

  • FlowGraph -> FlowGraphCollection
  • PartialFlowGraph -> TransposedFlowGraph

This PR fixes #137

@Entenwilli Entenwilli added enhancement New feature or request research Investigation or reserach related issue labels Mar 31, 2024
@Entenwilli Entenwilli added this to the 2.0.0 milestone Mar 31, 2024
@Entenwilli Entenwilli self-assigned this Mar 31, 2024
Copy link
Member

@Nicolas-Boltz Nicolas-Boltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comment, but still please look if the abbreviations are wrong at different places and fix them also.

@Entenwilli Entenwilli requested a review from Nicolas-Boltz April 2, 2024 07:40
Nicolas-Boltz
Nicolas-Boltz previously approved these changes Apr 3, 2024
Copy link
Member

@Nicolas-Boltz Nicolas-Boltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sebinside sebinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only found easy-to-fix inconsistencies, afterwards, this PR can be merged.

@sebinside sebinside merged commit f66ad3e into main Apr 3, 2024
@sebinside sebinside deleted the paper-renaming branch April 3, 2024 12:35
Nicolas-Boltz pushed a commit that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request research Investigation or reserach related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename flow graph related classes

3 participants