Skip to content

Add formatter guidelines#142

Merged
sebinside merged 3 commits intomainfrom
formatter-rule
Apr 3, 2024
Merged

Add formatter guidelines#142
sebinside merged 3 commits intomainfrom
formatter-rule

Conversation

@Entenwilli
Copy link
Member

As discussed in a meeting three or four weeks ago, we decided to use an adapted version of the JPlag Formatter Rules in this Repo.
Changes to the formatter are how we format stream expressions (each stream statement should be on a new line).

This PR closes issue #125

@Entenwilli Entenwilli added the enhancement New feature or request label Apr 2, 2024
@Entenwilli Entenwilli added this to the 3.0.0 milestone Apr 2, 2024
@Entenwilli Entenwilli self-assigned this Apr 2, 2024
@Entenwilli Entenwilli linked an issue Apr 2, 2024 that may be closed by this pull request
@Entenwilli
Copy link
Member Author

@Nicolas-Boltz Do you want to do the integration for the GitHub Actions Pipeline in this PR or in a separate PR?

@Nicolas-Boltz
Copy link
Member

@Entenwilli I do not want to do the integration for version 2.0.0 for now this is an improvement for a minor version later on :P

Copy link
Member

@Nicolas-Boltz Nicolas-Boltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! At some places I think it looks somewhat "wonky" however it is consistent and comprehensible

@Nicolas-Boltz Nicolas-Boltz modified the milestones: 3.0.0, 2.1.0, 2.0.0 Apr 3, 2024
@sebinside sebinside merged commit 15fefc9 into main Apr 3, 2024
@sebinside sebinside deleted the formatter-rule branch April 3, 2024 08:43
Nicolas-Boltz pushed a commit that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement formatting guidelines

3 participants