Skip to content

Fixes of ASs to DFD converter#145

Merged
sebinside merged 79 commits intomainfrom
fix-ass-conv
Apr 4, 2024
Merged

Fixes of ASs to DFD converter#145
sebinside merged 79 commits intomainfrom
fix-ass-conv

Conversation

@uuqjz
Copy link
Collaborator

@uuqjz uuqjz commented Apr 3, 2024

This PR addresses some fixes for the Ass to DFD converter

  • Fix duplicate edge creation due to orElse
  • Correctly resolve name for start and stop nodes
  • Enhance tests
  • Remove unnecessary getter from record

This PR has to be squashed!

@uuqjz uuqjz marked this pull request as ready for review April 3, 2024 16:18
@uuqjz uuqjz requested a review from sebinside April 3, 2024 16:18
Copy link
Member

@sebinside sebinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGNTM

@sebinside sebinside merged commit 4fa7923 into main Apr 4, 2024
@sebinside sebinside deleted the fix-ass-conv branch April 4, 2024 07:20
Nicolas-Boltz pushed a commit that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants