Skip to content

Fix improper filtering for PCM Vertices in Branches#187

Merged
sebinside merged 1 commit intomainfrom
pcm-filtering-fix
Jul 23, 2024
Merged

Fix improper filtering for PCM Vertices in Branches#187
sebinside merged 1 commit intomainfrom
pcm-filtering-fix

Conversation

@Entenwilli
Copy link
Member

This PR fixes the improper filtering of Start and End Nodes in PCM Branches.
Before this fix, characteristics would have been filtered by their name according to the available parameters of the SEFF signature. This erroneous filtering is removed, and instead characteristics are forwarded as normal

@Entenwilli Entenwilli added bug Something isn't working core Related to the core DFD/PCM data flow analysis labels Jul 23, 2024
@Entenwilli Entenwilli added this to the 3.0.0 milestone Jul 23, 2024
@Entenwilli Entenwilli self-assigned this Jul 23, 2024
Copy link
Member

@sebinside sebinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebinside sebinside removed the request for review from Nicolas-Boltz July 23, 2024 08:41
@sebinside sebinside merged commit 0d85676 into main Jul 23, 2024
@sebinside sebinside deleted the pcm-filtering-fix branch July 23, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working core Related to the core DFD/PCM data flow analysis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants