Rename equals methods to avoid collision issues#190
Merged
Conversation
Entenwilli
added
bug
sebinside
requested changes
Jul 24, 2024
Member
sebinside
left a comment
sebinside
left a comment
There was a problem hiding this comment.
Two minor points:
- Should a method that returns a boolean begin with
is, thusisEquivalentInContext? - Maybe some minor javadoc stating what we discussed yesterday, i.e., same ID + same calling and why this implies the same context?
Member
Author
|
Addressed in c88fbf8: |
sebinside
approved these changes
Jul 24, 2024
Member
sebinside
left a comment
sebinside
left a comment
There was a problem hiding this comment.
Feedback perfectly realized :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the
equalsMethods of PCM Elements toequivalentInContextto assure collision free lists of pcm vertices