Feat: Adding heuristics for faster DFD TFG finding and evaluation#198
Merged
Entenwilli merged 4 commits intomainfrom Aug 19, 2024
Merged
Feat: Adding heuristics for faster DFD TFG finding and evaluation#198Entenwilli merged 4 commits intomainfrom
Entenwilli merged 4 commits intomainfrom
Conversation
Entenwilli
previously approved these changes
Aug 17, 2024
Member
Entenwilli
left a comment
Entenwilli
left a comment
There was a problem hiding this comment.
LGTM! The cyclic flow graph finder is affected by all the changes as well, right?
Contributor
Author
I had to rename one method because of a similar parameter signature. But that should have no real consequences. |
BenjaminArp
reviewed
Aug 17, 2024
...sis.analysis.dfd/src/org/dataflowanalysis/analysis/dfd/core/DFDTransposeFlowGraphFinder.java
Outdated
Show resolved
Hide resolved
...sis.analysis.dfd/src/org/dataflowanalysis/analysis/dfd/core/DFDTransposeFlowGraphFinder.java
Show resolved
Hide resolved
...alysis.dfd/src/org/dataflowanalysis/analysis/dfd/core/DFDCyclicTransposeFlowGraphFinder.java
Show resolved
Hide resolved
BenjaminArp
approved these changes
Aug 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.