Feat: Adding a DFDModelResourceProvider to allow handing Models instances directly to analysis#212
Merged
Nicolas-Boltz merged 1 commit intomainfrom Sep 26, 2024
Merged
Conversation
…nces directly to the analysis
01Parzival10
added
enhancement
Nicolas-Boltz
approved these changes
Sep 26, 2024
Member
Nicolas-Boltz
left a comment
Nicolas-Boltz
left a comment
There was a problem hiding this comment.
This looks good to me, for now.
But we really need to think about refactoring the ResourceProviders in general.
@01Parzival10 If it does not already exist would you please create an issue regarding this refactoring?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.