Feat: Allow analysis to take absolute Paths without activator for both PCM and DFD#219
Merged
Feat: Allow analysis to take absolute Paths without activator for both PCM and DFD#219
Conversation
sebinside
requested changes
Nov 7, 2024
Member
sebinside
left a comment
sebinside
left a comment
There was a problem hiding this comment.
All changes boil down to:
- Get path
- If path absolute
- Use
URI.createFileURIand use this instead ofcreateRelativePluginURI
This could be generalized to 1. minimize code duplication 2. minimize the risk of subsequent faults in future resource providers / file types 3. support cases where only some of the paths are absolute (for whatever reason)
Contributor
Author
@sebinside Are these changes what you meant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For running the analysis standalone and using the converter properly it is necessary for the analysis to take absolute paths instead of relative plugin paths