If only a custom Ressource provider is provided old version failed --> now fixed#224
Merged
Entenwilli merged 7 commits intomainfrom Nov 27, 2024
Merged
If only a custom Ressource provider is provided old version failed --> now fixed#224Entenwilli merged 7 commits intomainfrom
Entenwilli merged 7 commits intomainfrom
Conversation
Contributor
|
Wait before merging. I'm currently writing a test or two for that |
01Parzival10
previously approved these changes
Nov 27, 2024
Contributor
01Parzival10
left a comment
01Parzival10
left a comment
There was a problem hiding this comment.
Can be merged after @Entenwilli had a look at it
Entenwilli
requested changes
Nov 27, 2024
Member
Entenwilli
left a comment
Entenwilli
left a comment
There was a problem hiding this comment.
Only one smaller comment about the SuppressWarnings annotations
...nalysis.analysis.tests/src/org/dataflowanalysis/analysis/tests/dfd/ResourceProviderTest.java
Outdated
Show resolved
Hide resolved
...nalysis.analysis.tests/src/org/dataflowanalysis/analysis/tests/dfd/ResourceProviderTest.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.