Skip to content

Allow the execution of the analysis via a CLI#233

Merged
Nicolas-Boltz merged 9 commits intomainfrom
analysis-binary
Feb 4, 2025
Merged

Allow the execution of the analysis via a CLI#233
Nicolas-Boltz merged 9 commits intomainfrom
analysis-binary

Conversation

@Entenwilli
Copy link
Member

@Entenwilli Entenwilli commented Dec 11, 2024 •
edited
Loading

This PR implements a CLI for the DFD and PCM analysis. It supports the following modes:

  • Interactive mode: The CLI asks for the files on the Standard Input
  • Arguments mode: The CLI takes the required parameters from the arguments passed to the binary

This PR begins progress towards closing #222

@Entenwilli Entenwilli added enhancement New feature or request core Related to the core DFD/PCM data flow analysis support Related to supporting projects which are neither core analysis or meta model bundels labels Dec 11, 2024
@Entenwilli Entenwilli added this to the 4.0.0 milestone Dec 11, 2024
@Entenwilli Entenwilli self-assigned this Dec 11, 2024
@Entenwilli Entenwilli marked this pull request as ready for review January 1, 2025 13:19
@01Parzival10
Copy link
Contributor

01Parzival10 commented Jan 7, 2025

The CLI should allow handing over a txt (or similar) with multiple constraints so they don't have to be typed manually everytime

@Entenwilli Entenwilli force-pushed the analysis-binary branch 2 times, most recently from 1ee75ac to ae595db Compare January 13, 2025 10:35
@Entenwilli
Copy link
Member Author

Entenwilli commented Jan 13, 2025

The CLI can now be executed with a .dfadsl file instead of providing a constraint on the command line

@Entenwilli
Copy link
Member Author

Entenwilli commented Jan 13, 2025

Therefore, this PR is also ready to be reviewed

sebinside
sebinside previously requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@sebinside sebinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor stuff. By now, we do not have test cases for the CLI (neither direct via cmd args nor indirect via the interactive cli). I do not find this critical as this is only UI stuff, with one exception: Are we sure that nothing can break when parsing the constraints? You added many (good!) unit test cases regarding the parsing as such, but can something bad happen in the code calling it?

@Entenwilli Entenwilli requested a review from sebinside January 25, 2025 13:16
@Entenwilli
Copy link
Member Author

Entenwilli commented Jan 25, 2025

Implemented the requested changes @sebinside

Nicolas-Boltz
Nicolas-Boltz previously approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@Nicolas-Boltz Nicolas-Boltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicolas-Boltz Nicolas-Boltz dismissed sebinside’s stale review February 4, 2025 12:13

loooks goooood toooo meeee

@Nicolas-Boltz Nicolas-Boltz self-requested a review February 4, 2025 12:13
@Nicolas-Boltz Nicolas-Boltz merged commit ef84e1a into main Feb 4, 2025
1 check passed
@Nicolas-Boltz Nicolas-Boltz deleted the analysis-binary branch February 4, 2025 12:17
Entenwilli pushed a commit that referenced this pull request Mar 30, 2025
@Nicolas-Boltz @Entenwilli
Merge pull request #233 from DataFlowAnalysis/analysis-binary
06b8eb5 
Allow the execution of the analysis via a CLI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nicolas-Boltz Nicolas-Boltz Nicolas-Boltz approved these changes

@sebinside sebinside Awaiting requested review from sebinside

Assignees

@Entenwilli Entenwilli

Labels

core Related to the core DFD/PCM data flow analysis enhancement New feature or request support Related to supporting projects which are neither core analysis or meta model bundels

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Entenwilli @01Parzival10 @sebinside @Nicolas-Boltz