Fix: In case of no incoming flow the unfulfilled TFG is skipped and warning is presented#234
Merged
Entenwilli merged 4 commits intomainfrom Jan 14, 2025
Merged
Fix: In case of no incoming flow the unfulfilled TFG is skipped and warning is presented#234Entenwilli merged 4 commits intomainfrom
Entenwilli merged 4 commits intomainfrom
Conversation
… warning is presented
Entenwilli
requested changes
Jan 13, 2025
Member
Entenwilli
left a comment
Entenwilli
left a comment
There was a problem hiding this comment.
Aside from the two really small changes, the formatting of the EdgeCaseTest class seems a bit off. Just format the file using the built-in Eclipse formatter
...ataflowanalysis.analysis.tests/src/org/dataflowanalysis/analysis/tests/dfd/EdgeCaseTest.java
Outdated
Show resolved
Hide resolved
...ataflowanalysis.analysis.tests/src/org/dataflowanalysis/analysis/tests/dfd/EdgeCaseTest.java
Outdated
Show resolved
Hide resolved
Entenwilli
added a commit
that referenced
this pull request
Jan 20, 2025
Fix: In case of no incoming flow the unfulfilled TFG is skipped and warning is presented
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the cyclic changes we introduced behavior that created TFG's for unfulfilled Nodes.
This PR adds a case distinction in which those sequences of nodes are skipped and a warning is presented to the User