Skip to content

Fix propagation bug#82

Merged
Nicolas-Boltz merged 4 commits intomainfrom
propagation-bug
Dec 19, 2023
Merged

Fix propagation bug#82
Nicolas-Boltz merged 4 commits intomainfrom
propagation-bug

Conversation

@Entenwilli
Copy link
Member

This PR generates action sequence elements for start and stop actions in User and SEFF elements. Furthermore, it fixes the propagation bug outlined in #78

@Entenwilli Entenwilli added the bug Something isn't working label Nov 30, 2023
@Entenwilli Entenwilli self-assigned this Nov 30, 2023
@Entenwilli Entenwilli linked an issue Nov 30, 2023 that may be closed by this pull request
@Entenwilli
Copy link
Member Author

I aim to merge this PR after the tests are reactivated from #83, because the tests need to be updated and checked

@sebinside sebinside mentioned this pull request Dec 5, 2023
13 tasks
@Entenwilli Entenwilli marked this pull request as ready for review December 19, 2023 11:19
@Entenwilli Entenwilli requested a review from sebinside December 19, 2023 11:20
@Entenwilli
Copy link
Member Author

This PR should be merged after #83

@Entenwilli Entenwilli force-pushed the propagation-bug branch 2 times, most recently from fc95bca to c45f850 Compare December 19, 2023 14:04
Copy link
Member

@Nicolas-Boltz Nicolas-Boltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicolas-Boltz Nicolas-Boltz merged commit ca81f2f into main Dec 19, 2023
@Nicolas-Boltz Nicolas-Boltz deleted the propagation-bug branch December 19, 2023 14:09
@sebinside sebinside added this to the 1.0.0 milestone Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

n-1 Bug: PCM Analysis does not follow the original specification

3 participants