Skip to content

Remove legacy leftovers from analysis and reactivate testcases#83

Merged
Nicolas-Boltz merged 8 commits intomainfrom
test-update
Dec 19, 2023
Merged

Remove legacy leftovers from analysis and reactivate testcases#83
Nicolas-Boltz merged 8 commits intomainfrom
test-update

Conversation

@Entenwilli
Copy link
Member

This PR removes legacy elements of the analysis, like EMF Profiles and indirections Data Stores. Furthermore, this PR updates and enables all test cases that were disabled in #80

@Entenwilli Entenwilli added the testing Related to testing and test cases or models label Nov 30, 2023
@Entenwilli Entenwilli self-assigned this Nov 30, 2023
@Entenwilli
Copy link
Member Author

After DataFlowAnalysis/PCM-DataFlowAnalysis-Extension#13 fixes bugs in the editor, I can fix the models present in this repository. As the Travel Planner Test Model uses Data Stores, it needs to be removed from our testing models. Or is there a version of the Travel Planner without Data Stores from Indirections, @sebinside @Nicolas-Boltz?

This was referenced Nov 30, 2023
@sebinside sebinside mentioned this pull request Dec 5, 2023
13 tasks
@Entenwilli Entenwilli marked this pull request as ready for review December 11, 2023 14:07
@Entenwilli Entenwilli requested a review from sebinside December 11, 2023 14:07
@Entenwilli
Copy link
Member Author

The tests in the repository have been re-enabled and updated for the new workspace. Results of the analysis are as expected (aside from the bug in #82)

Copy link
Member

@Nicolas-Boltz Nicolas-Boltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicolas-Boltz Nicolas-Boltz merged commit 5fb533e into main Dec 19, 2023
@Nicolas-Boltz Nicolas-Boltz deleted the test-update branch December 19, 2023 14:02
@sebinside sebinside added this to the 1.0.0 milestone Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Related to testing and test cases or models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove EMF profiles legacy once and for all Remove dependency to Indirections

3 participants