Merged
Conversation
Contributor
|
Hi @ludovicbellier, thank you very much for the PR! That looks great, I'd only suggest one minor thing though: since lines are repeated across multiple functions, could you maybe put those together into a small function (e.g., |
MMathisLab
requested review from
jeylau and
n-poulsen
and removed request for
jeylau
MMathisLab
added
WORK IN PROGRESS!
jeylau
approved these changes
Jul 25, 2023
Contributor
|
Hope you don't mind @ludovicbellier, I took the liberty to refactor the code myself as we'll merge your PR today. 😊 |
Contributor
|
Thanks @ludovicbellier! |
Contributor
Author
|
Woops sorry I was gone for a few days, thanks a lot @n-poulsen and @jeylau for the refactoring! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @n-poulsen and team DLC!
Here is a PR solving #2312: after TF import (or first call if lazy loading is enabled),
os.environ['CUDA_VISIBLE_DEVICES']has no effect anymore, so I replaced it bytf.config.set_visible_devices()(the TensorFlow equivalent oftorch.cuda.set_device(); hat tip to this message). Also added an explicit error message ifgputouseis out of the range of available GPUs.Made this replacement for all four
if gputouse is not None:statements inpredict_videos.py, although I only (explicitly) useanalyze_videos()(which I just tried, and it worked perfectly!).Best,
Ludovic