Use stats with changed download for disconnect notification#385
Merged
t-aleksander merged 4 commits intodevfrom Feb 13, 2025
Merged
Use stats with changed download for disconnect notification#385t-aleksander merged 4 commits intodevfrom
t-aleksander merged 4 commits intodevfrom
Conversation
wojcik91
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The disconnect is now detected based on the time of the latest stat which download has changed, as this indicates a successful two-way communication. Previous implementation queried just the last stat which can be wrong as the client may perform unsuccessful connection attempts creating stats record with only upload changing