[ethereum-block-by-date] update types for version 1.4.3#59762
[ethereum-block-by-date] update types for version 1.4.3#59762typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom alexandre-abrioux:ethereum-block-by-date-1.4.3
Conversation
|
@alexandre-abrioux Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59762,
"author": "alexandre-abrioux",
"headCommitOid": "a8d4d3b7708d734ae446910c4a578c5fc92a2b8a",
"mergeBaseOid": "462a51fd76492a4e16ca2370f2aa57fc42f87c5e",
"lastPushDate": "2022-04-08T08:58:22.000Z",
"lastActivityDate": "2022-04-08T16:08:07.000Z",
"mergeOfferDate": "2022-04-08T15:51:22.000Z",
"mergeRequestDate": "2022-04-08T16:08:07.000Z",
"mergeRequestUser": "alexandre-abrioux",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "ethereum-block-by-date",
"kind": "edit",
"files": [
{
"path": "types/ethereum-block-by-date/ethereum-block-by-date-tests.ts",
"kind": "test"
},
{
"path": "types/ethereum-block-by-date/index.d.ts",
"kind": "definition"
}
],
"owners": [
"alexandre-abrioux"
],
"addedOwners": [
"monosux"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "monosux",
"date": "2022-04-08T15:50:42.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1092622814,
"ciResult": "pass"
} |
typescript-bot
added
Edits Owners
|
🔔 @alexandre-abrioux — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
typescript-bot
added
Other Approved
|
@alexandre-abrioux: Everything looks good here. I am ready to merge this PR (at a8d4d3b) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
3 participants
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
Introduced Changes:
refreshparameter as requested in Type definitions monosux/ethereum-block-by-date#25 (comment)ethereum-block-by-date's owner (@monosux) as a Definition Owner.