Conversation
Old-style octal literals become syntax errors in an upcoming TS PR: microsoft/TypeScript#51837 But syntax errors can't be silenced with ts-expect-error, and the octal literal is not important to the vk-openapi test in question, so change it to use new octal syntax.
Contributor
|
@sandersn Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 64741,
"author": "sandersn",
"headCommitOid": "624f965d9e9cd0b71786443b0f3ab5e1df34226b",
"mergeBaseOid": "80e2d4f1e7116f59d1243f98b4d4d25bdb8f8a15",
"lastPushDate": "2023-03-14T16:25:34.000Z",
"lastActivityDate": "2023-03-14T16:27:17.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "vk-openapi",
"kind": "edit",
"files": [
{
"path": "types/vk-openapi/vk-openapi-tests.ts",
"kind": "test"
}
],
"owners": [
"hikiko4ern"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2023-03-14T16:27:17.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1468426733,
"ciResult": "pass"
} |
Contributor
|
🔔 @hikiko4ern — please review this PR in the next few days. Be sure to explicitly select |
jakebailey
approved these changes
Mar 14, 2023
typescript-bot
added
Maintainer Approved
Self Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old-style octal literals become syntax errors in an upcoming TS PR: microsoft/TypeScript#51837 But syntax errors can't be silenced with ts-expect-error, and the octal literal is not important to the vk-openapi test in question, so change it to use new octal syntax.