fix: Unsubscribe the tiled writer unsubscriber#1301
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1301 +/- ##
==========================================
+ Coverage 94.76% 94.99% +0.22%
==========================================
Files 42 42
Lines 2752 2755 +3
==========================================
+ Hits 2608 2617 +9
+ Misses 144 138 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tpoliaw
changed the title
tpoliaw
force-pushed
the
remove-tiled-remover
branch
from
97e4314 to
f285529
Compare
tpoliaw
force-pushed
the
remove-tiled-remover
branch
from
f285529 to
22ae87a
Compare
tpoliaw
force-pushed
the
remove-tiled-remover
branch
from
22ae87a to
59b73b7
Compare
When the tiled writer subscribes to the run_engine, another callback subscribes to the task worker to remove the writer at the end of the plan/task. This subscriber should also be removed at the end of the task. To avoid creating a third subscriber and the same issue again, rely on the unsubscribe handle created after the callback is defined being available in the closure when it runs. There is a very slight race condition here if the task complete event is received before the subscribe method returns but until it happens we'll assume it's unlikely.
tpoliaw
force-pushed
the
remove-tiled-remover
branch
from
59b73b7 to
3525f6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the tiled writer subscribes to the run_engine, another callback
subscribes to the task worker to remove the writer at the end of the
plan/task. This subscriber should also be removed at the end of the
task.
To avoid creating a third subscriber and the same issue again, rely on
the unsubscribe handle created after the callback is defined being
available in the closure when it runs. There is a very slight race
condition here if the task complete event is received before the
subscribe method returns but until it happens we'll assume it's
unlikely.