refactor: Cleanup defaults for blueapi server#1385
Merged
ZohebShaikh merged 3 commits intomainfrom Feb 13, 2026
Merged
Conversation
ZohebShaikh
force-pushed
the
use-class-vars
branch
from
92a700a to
763b6a2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
==========================================
- Coverage 95.03% 95.03% -0.01%
==========================================
Files 43 43
Lines 2780 2779 -1
==========================================
- Hits 2642 2641 -1
Misses 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ZohebShaikh
force-pushed
the
use-class-vars
branch
from
763b6a2 to
d962797
Compare
dan-fernandes
approved these changes
Feb 13, 2026
Contributor
dan-fernandes
left a comment
dan-fernandes
left a comment
There was a problem hiding this comment.
LGTM, very sensible
Contributor
|
What's the benefit of moving all the non-configurable things into config? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.