Skip to content

fix: Change StatusView precision type to int | None#1438

Merged
shree-iyengar-dls merged 5 commits intomainfrom
124_0_or_not_set_precision_is_overwritten
Mar 18, 2026
Merged

fix: Change StatusView precision type to int | None#1438
shree-iyengar-dls merged 5 commits intomainfrom
124_0_or_not_set_precision_is_overwritten

Conversation

@shree-iyengar-dls
Copy link
Contributor

Fixes #124 Changed 3 to None

@shree-iyengar-dls shree-iyengar-dls requested a review from a team as a code owner March 10, 2026 12:13
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.19%. Comparing base (e7eae6c) to head (5aaef49).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1438   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files          43       43           
  Lines        3119     3119           
=======================================
  Hits         2969     2969           
  Misses        150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shree-iyengar-dls shree-iyengar-dls self-assigned this Mar 10, 2026
Copy link
Contributor

@dan-fernandes dan-fernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: non-descriptive PR title. Something more like "fix: Change StatusView precision type to int | None" would let me know what's happening in one glance

@shree-iyengar-dls shree-iyengar-dls changed the title fix: change default from 3 to None fix: Change StatusView precision type to int | None Mar 18, 2026
@shree-iyengar-dls shree-iyengar-dls merged commit bacea37 into main Mar 18, 2026
18 checks passed
@shree-iyengar-dls shree-iyengar-dls deleted the 124_0_or_not_set_precision_is_overwritten branch March 18, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 or not set precision is overwritten

2 participants