Conversation
10e4b27 to
4942f58
Compare
7d5ac4f to
83988c6
Compare
e237ace to
c179fc0
Compare
cb5d2ed to
d92b878
Compare
b6f466d to
168c024
Compare
Trouffman
reviewed
Jul 17, 2024
Trouffman
reviewed
Jul 18, 2024
I did discuss this w/ the OBS team: https://discord.com/channels/348973006581923840/374636084883095554/1240927807828267090 > pvhaus (PST/UTC-8) — 05/17/2024 12:24 AM > Would a question about the code in obsplugin-template be better asked here or in plugins-and-tools ? > While I am occupying space here, my question is https://github.com/obsproject/obs-plugintemplate/pull/76/files#r1604462761  > PatTheMav — 05/17/2024 2:27 PM > no need for DMs, the answer is "I have no clue" > I just replaced the value with a CMake replacement, no idea what is "correct" there > ... > RytoEX — 05/17/2024 2:31 PM > Anyway, this is (sort of) covered in the Inno docs: > > A "{" character is treated as the start of the constant. If you want to use that > > actual character in a place where constants are supported, you must use > > two consecutive "{" characters. (You do not need to double "}" characters.) > > https://jrsoftware.org/ishelp/ > So I'd guess that the desired constant value is: > {CD703FE5-1F2C-4837-BD3D-DD840D83C3E3} > > or: > {@UUID_APP@} > > and doubling the { character achieves that. > Or it's a mistake, but I'm in no condition at the moment to dig further. > RytoEX — 05/17/2024 2:38 PM > I guess the real question is: are you having any issues stemming from this syntax? > If not, then it's probably working as intended. > pvhaus (PST/UTC-8) — 05/17/2024 8:20 PM > No, it just caught my eye as a little odd. I am trying some builds on my plug-in (obs-ndi) to see if it makes any difference (fixes or breaks anything) So, that made me second guess my change.
Trouffman
reviewed
Jul 19, 2024
data/locale/fr-FR.ini
Outdated
| NDIPlugin.Update.NoUpdateAvailable="Aucune mise à jour de %1 disponible" | ||
| NDIPlugin.Update.YouAreUpToDate="Vous avez déjà la dernière version %1 de %2." | ||
|
|
||
| NDIPlugin.Donate="Veuillez envisager de faire un don pour soutenir ce projet :" |
Collaborator
There was a problem hiding this comment.
Suggested :
NDIPlugin.Donate="Faites un don pour soutenir ce projet :"
More direct & to the point.
Member
Author
There was a problem hiding this comment.
No "Please consider"?
Man! Those French really are rude! :)
I did just notice that stray whitespace. :/
Note to self: Diff this commit to the previous and eventually roll anything worthy into a future release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code requires an update server to be running at https://distroav.org/api/update.
The update server is a Firebase Function with code at https://github.com/DistroAV/firebase/blob/main/functions/index.js
Much of this PR duplicates PR #960.
I would like to merge this PR in as a 4.x version and then PR #960 as a 6.x that support NDI 6.x
I will resolve any conflicts when I merge master into #960