Skip to content

New Feature: Check For Update#1028

Merged
paulpv merged 24 commits intomasterfrom
update
Jul 21, 2024
Merged

New Feature: Check For Update#1028
paulpv merged 24 commits intomasterfrom
update

Conversation

@paulpv
Copy link
Member

@paulpv paulpv commented May 21, 2024

This code requires an update server to be running at https://distroav.org/api/update.
The update server is a Firebase Function with code at https://github.com/DistroAV/firebase/blob/main/functions/index.js

Much of this PR duplicates PR #960.
I would like to merge this PR in as a 4.x version and then PR #960 as a 6.x that support NDI 6.x
I will resolve any conflicts when I merge master into #960

@paulpv paulpv force-pushed the update branch 2 times, most recently from 10e4b27 to 4942f58 Compare July 7, 2024 21:55
@paulpv paulpv force-pushed the update branch 5 times, most recently from 7d5ac4f to 83988c6 Compare July 8, 2024 05:37
@paulpv paulpv force-pushed the update branch 4 times, most recently from e237ace to c179fc0 Compare July 8, 2024 23:09
@paulpv paulpv force-pushed the update branch 13 times, most recently from cb5d2ed to d92b878 Compare July 14, 2024 09:51
@paulpv paulpv force-pushed the update branch 5 times, most recently from b6f466d to 168c024 Compare July 17, 2024 09:35
paulpv added 3 commits July 17, 2024 23:19
I did discuss this w/ the OBS team:
https://discord.com/channels/348973006581923840/374636084883095554/1240927807828267090

> pvhaus (PST/UTC-8) — 05/17/2024 12:24 AM
> Would a question about the code in obsplugin-template be better asked here or in ⁠plugins-and-tools ?
> While I am occupying space here, my question is https://github.com/obsproject/obs-plugintemplate/pull/76/files#r1604462761
![image](https://github.com/user-attachments/assets/d7e60b33-2320-49e0-969a-a2f0bf662da5)
> PatTheMav — 05/17/2024 2:27 PM
> no need for DMs, the answer is "I have no clue"
> I just replaced the value with a CMake replacement, no idea what is "correct" there
> ...
> RytoEX — 05/17/2024 2:31 PM
> Anyway, this is (sort of) covered in the Inno docs:
> > A "{" character is treated as the start of the constant. If you want to use that
> > actual character in a place where constants are supported, you must use
> > two consecutive "{" characters. (You do not need to double "}" characters.)
>
> https://jrsoftware.org/ishelp/
> So I'd guess that the desired constant value is:
> {CD703FE5-1F2C-4837-BD3D-DD840D83C3E3}
>
> or:
> {@UUID_APP@}
>
> and doubling the { character achieves that.
> Or it's a mistake, but I'm in no condition at the moment to dig further.
> RytoEX — 05/17/2024 2:38 PM
> I guess the real question is: are you having any issues stemming from this syntax?
> If not, then it's probably working as intended.
> pvhaus (PST/UTC-8) — 05/17/2024 8:20 PM
> No, it just caught my eye as a little odd. I am trying some builds on my plug-in (obs-ndi) to see if it makes any difference (fixes or breaks anything)

So, that made me second guess my change.
NDIPlugin.Update.NoUpdateAvailable="Aucune mise à jour de %1 disponible"
NDIPlugin.Update.YouAreUpToDate="Vous avez déjà la dernière version %1 de %2."

NDIPlugin.Donate="Veuillez envisager de faire un don pour soutenir ce projet :"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested :
NDIPlugin.Donate="Faites un don pour soutenir ce projet :"
More direct & to the point.

Copy link
Member Author

@paulpv paulpv Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No "Please consider"?
Man! Those French really are rude! :)

I did just notice that stray whitespace. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Seeking Testers PRs with this label will package the plugin so that others can test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants