Merged
Conversation
Member
paulpv
commented
Jul 31, 2024
paulpv
commented
- misc: Add util build-ish scripts I regularly use during development
- cleanup: Change all APPLE/linux/_WIN32 to Q_OS_MAC/LINUX/WIN
- config: Make all uses of Config::Current() consistent
- filter/output/source: make impl & logging more consistent
- ...?
Plus some other misc cleanups: * Comments * Fixing shadowed variables * `static_cast`ing C++ classes * `#if 0` debug/test lines
Make `Config::Load()` private. Change `Config::Current()` to `Config::Current(bool load)` Most all places consistently call `config = Config::Current()` instead of a mix of that and `conf = Config::Current()`. Some places didn't load when they needed to. Some places didn't need to load but now explictily opt out. None of the loads are done in high performance loops.
paulpv
force-pushed
the
6.0.0_final_touches
branch
from
0aaf486 to
85242ee
Compare
Member
Author
|
@Trouffman for your review, if you are able |
Merged
Member
Author
|
@Trouffman It has been over 36 hours since this code's last push. Any concerns, or may I merge? |
Trouffman
approved these changes
Aug 2, 2024
Collaborator
Trouffman
left a comment
Trouffman
left a comment
There was a problem hiding this comment.
Changes do make sense! Love the extra debug info in the logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.