Conversation
…requirement byt he plugin (not fully tested yet)
Collaborator
Author
|
This is ready for review / testing. There are a LOT of changes, including changes to default github actions and code formatting process. please check the latest artefacts and try on your system, report any bug that are not in master branch, |
Collaborator
Author
|
This is no longer. WIP and should be tested on the major OS. |
Follow OBS for log entries guideline (non-capitalized) Update with plugin-template code where missing
Collaborator
Author
|
This requires OBS 31. there are some possible clean-up to be pushed as well later with the work on the new config files |
…istroAV into obs_31_min_req_update
Collaborator
Author
|
An Important point on this PR: The obs-plugintemplate moved away from providing & maintaining build script for innosetup outside of the CI environment. This brings us to a choice:
-or-
Planned features could be implemented at:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aim to use the updated OBS Plugin Template.
There are a major lack of documentation about the changes and this process is highly manual.
Goal is:
No other changes should be made as well (no new features / bug fix etc).
There are a bunch of changes that would impact the obs_log but this is too complex and will be dealt in another PR once this is merged.
Impacts:
Windows build process has change, this PR will wipe the tweaks from {PR 1134](Auto remove obs-ndi - Windows #1134) > Could be looked at to be managed by a script. (if deemed relevant still)
MacOS build as well will not have the scripts (postinstall) as well as PR Remove obs-ndi on macos after install of DistroAV #1158 & PR Delete obs-ndi plugin on macos after installing DistroAV #1136
This could be re-implemented via specific PR is relevant.